Support extensions and custom controller flags in deploy-to-kube tool#511
Merged
k8s-ci-robot merged 5 commits intokubernetes-sigs:mainfrom Apr 7, 2026
Merged
Conversation
k8s-ci-robot
added
size/L
Contributor
Author
|
@barney-s let me know if you'd prefer this broken down into separate PRs. |
✅ Deploy Preview for agent-sandbox canceled.
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
justinsb
approved these changes
Apr 2, 2026
| container["args"] = [] | ||
| flags = flags_str.split() | ||
| for flag in flags: | ||
| if flag not in container["args"]: |
Contributor
There was a problem hiding this comment.
We might need to enhance this logic in future, but I think it's a great start. (e.g. --v=2 => --v=8)
k8s-ci-robot
added
the
approved
Contributor
|
/retest |
Contributor
|
@igooch - Could you please investigate the e2e failures ? |
igooch
force-pushed
the
deploy-extensions
branch
from
a1279fd to
df5e558
Compare
k8s-ci-robot
removed
the
lgtm
igooch
force-pushed
the
deploy-extensions
branch
from
df662ec to
d8e34d5
Compare
barney-s
approved these changes
Apr 7, 2026
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aditya-shantanu, barney-s, igooch, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the deployment tools to support optional extensions and custom controller configuration.
--extensionsflag to deploy the extensions resources to the cluster.--controller-argsflag to pass arbitrary arguments (e.g., --zap-log-level=debug) directly to the controller container.kubectl patchlogic in the Makefile with a native--extensionsflag in the deployment script.This makes the
make deploy-kindand./dev/tools/deploy-to-kubetargets much more helpful when developing for the extensions controllers.